Skip to content

Add In Search of the Myreque quest - #1255

Merged
GregHib merged 7 commits into
mainfrom
in-search-of-the-myreque
Sep 8, 2026
Merged

Add In Search of the Myreque quest#1255
GregHib merged 7 commits into
mainfrom
in-search-of-the-myreque

Conversation

@Ebp90

@Ebp90 Ebp90 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Cutscene is repurposed from the 2011 version, as vampire graphical update had not come out yet.

Swamp Tree has AP issues.

Ebp90 and others added 7 commits September 8, 2026 14:44
@Ebp90 @claude @GregHib
Add In Search of the Myreque quest
28d39e2 
Full quest from Vanstrom's request in the Canifis tavern through to the
escape back up into Canifis: the boat negotiation with Cyreg, the rope
bridge repaired a rung at a time, Curpile Fyod's questions, meeting the
Myreque, and Vanstrom's ambush of the hideout.

Quest stages are referenced by the names declared in the quest's varp
rather than by their numbers, via a new questStage(quest, stage) lookup.

DynamicZones gains a zone-block copy so a cutscene can be staged in a copy
of a few rooms rather than a whole region.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K22iXYZjnQnTr3ZUtbuGBG
@GregHib
Fix vanstrom evil laugh dialogue
2bf14b2
@GregHib
Fix early exiting cutscene
db484ea
@GregHib
Fix having a sickle equipped
b06db75
@GregHib
Fix swamp bridge tree approach issue
fec8bb6
@GregHib
Dialogue formatting
217a46c
@GregHib
Add dialogue formatting tool
7af2c6b
@GregHib
GregHib force-pushed the in-search-of-the-myreque branch from d59f80c to 7af2c6b Compare September 8, 2026 13:45
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Qodana for JVM

10 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 10

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.64627% with 553 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.92%. Comparing base (f8a8b16) to head (7af2c6b).

Files with missing lines Patch % Lines
...content/area/morytania/mort_ton/CyregPaddlehorn.kt 25.46% 109 Missing and 11 partials ⚠️
...tent/area/morytania/mort_myre_swamp/VeliafHurtz.kt 57.56% 95 Missing and 6 partials ⚠️
...tlin/content/quest/member/myreque/SearchMyreque.kt 80.14% 26 Missing and 30 partials ⚠️
...n/content/area/morytania/canifis/VanstromKlause.kt 48.93% 47 Missing and 1 partial ⚠️
...tent/area/morytania/mort_myre_swamp/CurpileFyod.kt 71.52% 35 Missing and 6 partials ⚠️
...area/morytania/mort_myre_swamp/PolmafiFerdygris.kt 7.14% 39 Missing ⚠️
...tent/area/morytania/mort_myre_swamp/HaroldEvans.kt 7.31% 38 Missing ⚠️
...ontent/area/morytania/mort_myre_swamp/IvanStrom.kt 7.31% 38 Missing ⚠️
...nt/area/morytania/mort_myre_swamp/RadigadPonfit.kt 7.89% 35 Missing ⚠️
...ontent/area/morytania/mort_myre_swamp/SaniPiliu.kt 47.82% 20 Missing and 4 partials ⚠️
... and 5 more
Additional details and impacted files
Files with missing lines Coverage Δ
...in/content/area/morytania/canifis/CanifisTavern.kt 27.27% <ø> (-3.50%) ⬇️
...world/gregs/voidps/engine/map/zone/DynamicZones.kt 73.43% <80.00%> (+0.55%) ⬆️
game/src/main/kotlin/content/quest/Cutscene.kt 92.15% <87.50%> (-0.40%) ⬇️
game/src/main/kotlin/content/quest/Quest.kt 68.57% <66.66%> (+8.86%) ⬆️
.../area/morytania/mort_myre_swamp/MyrequeStranger.kt 88.57% <88.57%> (ø)
...ntent/area/morytania/mort_myre_swamp/SwampyBoat.kt 60.71% <60.00%> (+50.07%) ⬆️
...ontent/area/morytania/mort_myre_swamp/SaniPiliu.kt 47.82% <47.82%> (ø)
...nt/area/morytania/mort_myre_swamp/RadigadPonfit.kt 7.89% <7.89%> (ø)
...tent/area/morytania/mort_myre_swamp/HaroldEvans.kt 7.31% <7.31%> (ø)
...ontent/area/morytania/mort_myre_swamp/IvanStrom.kt 7.31% <7.31%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1255      +/-   ##
============================================
+ Coverage     43.76%   43.92%   +0.16%     
- Complexity    10583    10711     +128     
============================================
  Files          2072     2081       +9     
  Lines         94871    96029    +1158     
  Branches      15380    15501     +121     
============================================
+ Hits          41518    42180     +662     
- Misses        47401    47833     +432     
- Partials       5952     6016      +64
Components Coverage Δ
Content 44.21% <53.53%> (+0.20%) ⬆️
Engine 45.68% <80.00%> (+0.01%) ⬆️
Network 71.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib
GregHib merged commit b178eab into main Sep 8, 2026
5 checks passed
@GregHib
GregHib deleted the in-search-of-the-myreque branch September 8, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ebp90 @GregHib